This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Modified to work with one table. Added "provider" field. Removed old mig... #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…migrations. Added new one.
Whoops. Had provider field as integer instead of text. Fixed that.
|
Totally awesome, thanks for your work. |
|
Tested this with Github and Bitbucket and both of them did the "tokening". I did the test without a user to see what would happen, messagebag had the "missing user" error as expected, no colossal failure - page still loaded as expected. |
|
The bug with cURL I has was making post requests to set up a deploy hook.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rations. Added new one.
Although after digging through the code, I think maybe it should be made an option in the config about whether or not to even use the table or not. Some devs might not need this option, or are using their own tables already, so having a config option of "use_table = [true, false, 'tablename']" might be a better way to go....?